[
https://issues.apache.org/jira/browse/HADOOP-14998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233916#comment-16233916
]
Steve Loughran commented on HADOOP-14998:
-----------------------------------------
* The stuff is in hadoop-auth, so not in hadoop-common, more broadly used.
* if its marked up as public (& evolving?) in trunk, well, people can use it in
3.0 and then point to the 3.1 change as a sign that it's OK to use.
Don't have opinions on whether this API should be made public. Wanting to make
it so should actually be a good opportunity to review the code to see if it
really is stable enough to be tagged as public & whether there is enough test
coverage for any guarantees about stability & functionality to be defensible.
Risk here is that it's getting close to jetty & kerberos, where changes over
versions can be observable.
> Make AuthenticationFilter @Public
> ---------------------------------
>
> Key: HADOOP-14998
> URL: https://issues.apache.org/jira/browse/HADOOP-14998
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.0.0
> Reporter: Robert Kanter
> Assignee: Bharat Viswanadham
> Priority: Major
>
> {{org.apache.hadoop.security.authentication.server.AuthenticationFilter}} is
> currently marked as {{\@Private}} and {{\@Unstable}}.
> {code:java}
> @InterfaceAudience.Private
> @InterfaceStability.Unstable
> public class AuthenticationFilter implements Filter {
> {code}
> However, many other projects (e.g. Oozie, Hive, Solr, HBase, etc) have been
> using it for quite some time without having any compatibility issues AFAIK.
> It doesn't seem to have had any breaking changes in quite some time. On top
> of that, it implements {{javax.servlet.Filter}}, so it can't change too
> widely anyway. {{AuthenticationFilter}} provides a lot of useful code for
> dealing with tokens, Kerberos, etc, and we should encourage related projects
> to re-use this code instead of rolling their own.
> I propose we change it to {{\@Public}} and {{\@Evolving}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
