[
https://issues.apache.org/jira/browse/HADOOP-7227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028456#comment-13028456
]
Tsz Wo (Nicholas), SZE commented on HADOOP-7227:
------------------------------------------------
+1
Minor: The following codes repeat twice. It may deserve putting them in a
utility method. Otherwise, we won't miss the other "versionID" previously.
{code}
+ try {
+ Field versionField = method.getDeclaringClass().getField("versionID");
+ versionField.setAccessible(true);
+ clientVersion = versionField.getLong(method.getDeclaringClass());
+ } catch (NoSuchFieldException ex) {
+ throw new RuntimeException(ex);
+ } catch (IllegalAccessException ex) {
+ throw new RuntimeException(ex);
+ }
{code}
> Remove protocol version check at proxy creation in Hadoop RPC.
> --------------------------------------------------------------
>
> Key: HADOOP-7227
> URL: https://issues.apache.org/jira/browse/HADOOP-7227
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.23.0
>
> Attachments: HADOOP-7227.2.patch, HADOOP-7227.3.patch,
> HADOOP-7227.4.patch, HADOOP-7227.5.patch, HADOOP-7227.6.patch
>
>
> Currently when a proxy is created for a protocol, there is a round trip of
> messages to check the protocol version. The protocol version is not checked
> in any subsequent rpc which could be a problem if the server restarts with a
> new protocol version. This issue and also the additional round-trip at proxy
> creation can be avoided if we add the protocol version in every rpc, and
> server checks the protocol version for every call.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
