[
https://issues.apache.org/jira/browse/HADOOP-15023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254461#comment-16254461
]
Lei (Eddy) Xu commented on HADOOP-15023:
----------------------------------------
+1. LGTM.
Thanks [~xiaochen]
> ValueQueue should also validate (lowWatermark * numValues) > 0 on construction
> ------------------------------------------------------------------------------
>
> Key: HADOOP-15023
> URL: https://issues.apache.org/jira/browse/HADOOP-15023
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Priority: Minor
> Attachments: HADOOP-15023.01.patch
>
>
> ValueQueue has precondition checks for each item independently, but does not
> check {{(int)(lowWatermark * numValues) > 0}}. If the product is low enough,
> casting to int will wrap that to 0, causing problems later when filling /
> getting from the queue.
> [code|https://github.com/apache/hadoop/blob/branch-3.0.0-beta1/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/ValueQueue.java#L224]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
