[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257912#comment-16257912
]
Ping Liu commented on HADOOP-14600:
-----------------------------------
[~chris.douglas] excellent catch! Your correction is perfect. Yes,
{{recursive}} is boolean and will instruct {{Shell.getSetPermissionCommand()}}
to get "set permission command" either recursively or not based on the flag.
Currently, only non-recursive mode is used. But in the future, recursive mode
can be used when needed.
Other changes look good. Thanks for detailed changes! The only question I
have is the number of spaces for indentation. I notice you are using two
spaces in {{StatUtils}}. I was using two-space before as I think this saves
space but was told four-space should be used for readability as two-space looks
busy. Oh, as I just read the Oracle/Sun code convention, it says indentation
should be four spaces. Other than indentation, all else look good. Thanks
Chris!
> LocatedFileStatus constructor forces RawLocalFS to exec a process to get the
> permissions
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-14600
> URL: https://issues.apache.org/jira/browse/HADOOP-14600
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.7.3
> Environment: file:// in a dir with many files
> Reporter: Steve Loughran
> Assignee: Ping Liu
> Attachments: HADOOP-14600.001.patch, HADOOP-14600.002.patch,
> HADOOP-14600.003.patch, HADOOP-14600.004.patch, HADOOP-14600.005.patch,
> HADOOP-14600.006.patch, HADOOP-14600.007.patch, HADOOP-14600.008.patch,
> TestRawLocalFileSystemContract.java
>
>
> Reported in SPARK-21137. a {{FileSystem.listStatus}} call really craws
> against the local FS, because {{FileStatus.getPemissions}} call forces
> {{DeprecatedRawLocalFileStatus}} tp spawn a process to read the real UGI
> values.
> That is: for every other FS, what's a field lookup or even a no-op, on the
> local FS it's a process exec/spawn, with all the costs. This gets expensive
> if you have many files.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
