[ https://issues.apache.org/jira/browse/HADOOP-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263285#comment-16263285 ]
Xiao Chen edited comment on HADOOP-15067 at 11/22/17 8:22 PM: -------------------------------------------------------------- +1 pending jenkins. Thanks Misha. Also thanks [~xkrogen] for the good catch. Do you have any other comments Erik? [~andrew.wang] FYI this would be a useful supportability fix that we'd like to add to 3.0.0, so downstream could use hadoop-3.0.0 package. was (Author: xiaochen): +1 pending jenkins. Thanks Misha. [~andrew.wang] FYI this would be a useful supportability fix that we'd like to add to 3.0.0, so downstream could use hadoop-3.0.0 package. > GC time percentage reported in JvmMetrics should be a gauge, not counter > ------------------------------------------------------------------------ > > Key: HADOOP-15067 > URL: https://issues.apache.org/jira/browse/HADOOP-15067 > Project: Hadoop Common > Issue Type: Bug > Reporter: Misha Dmitriev > Assignee: Misha Dmitriev > Attachments: HADOOP-15067.01.patch > > > A new GcTimeMonitor class has been recently added, and the corresponding > metrics added in JvmMetrics.java, line 190: > {code} > if (gcTimeMonitor != null) { > rb.addCounter(GcTimePercentage, > gcTimeMonitor.getLatestGcData().getGcTimePercentage()); > } > {code} > Since GC time percentage can go up and down, a gauge rather than counter > should be used to report it. That is, {{addCounter}} should be replaced with > {{addGauge}} above. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org