[
https://issues.apache.org/jira/browse/HADOOP-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263893#comment-16263893
]
Erik Krogen commented on HADOOP-15067:
--------------------------------------
Thanks for the ping [~xiaochen] and sorry for the late response, as you seem to
have suspected I was OOO for the holidays today. And thank you for the fix
[[email protected]]! LGTM.
> GC time percentage reported in JvmMetrics should be a gauge, not counter
> ------------------------------------------------------------------------
>
> Key: HADOOP-15067
> URL: https://issues.apache.org/jira/browse/HADOOP-15067
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Misha Dmitriev
> Assignee: Misha Dmitriev
> Attachments: HADOOP-15067.01.patch
>
>
> A new GcTimeMonitor class has been recently added, and the corresponding
> metrics added in JvmMetrics.java, line 190:
> {code}
> if (gcTimeMonitor != null) {
> rb.addCounter(GcTimePercentage,
> gcTimeMonitor.getLatestGcData().getGcTimePercentage());
> }
> {code}
> Since GC time percentage can go up and down, a gauge rather than counter
> should be used to report it. That is, {{addCounter}} should be replaced with
> {{addGauge}} above.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
