[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271676#comment-16271676
]
Jack Bearden commented on HADOOP-15056:
---------------------------------------
Forgive me if I am being too pedantic... The way I see it, by guarding with the
hasCapability for StreamCapabilities.UNBUFFER, we may effectively be neglecting
the possibility of ever encountering that UnsupportedOperationException. That
may result in the user no longer getting the error message in their logs.
Are there any other use cases where that exception would be thrown? Note: it
appears you fixed this with the latest patch but I am still trying to
understand why.
Thank you for your patience
> Fix TestUnbuffer#testUnbufferException failure
> ----------------------------------------------
>
> Key: HADOOP-15056
> URL: https://issues.apache.org/jira/browse/HADOOP-15056
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.9.0
> Reporter: Jack Bearden
> Assignee: Jack Bearden
> Priority: Minor
> Attachments: HADOOP-15056.001.patch, HADOOP-15056.002.patch
>
>
> Hello! I am a new contributor and actually contributing to open source for
> the very first time. :)
> I pulled down Hadoop today and when running the tests I encountered a failure
> with the TestUnbuffer#testUnbufferException test.
> The unbuffer code has recently gone through some changes and I believe this
> test case may have been overlooked. Using today's git commit
> (659e85e304d070f9908a96cf6a0e1cbafde6a434), and upon running the test case,
> there is an expect mock for an exception UnsupportedOperationException that
> is no longer being thrown.
> It would appear that a test like this would be valuable so my initial
> proposed patch did not remove it. Instead, I removed the conditions that were
> guarding the cast from being able to fire -- as was the previous behavior.
> Now when we encounter an object that doesn't have the UNBUFFERED
> StreamCapability, it will throw an error as it did prior to the recent
> changes.
> Please review and let me know what you think! :D
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
