[ 
https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029999#comment-13029999
 ] 

Thomas Graves commented on HADOOP-7248:
---------------------------------------

     [exec] -1 overall.    
     [exec]     [exec]     +1 @author.  The patch does not contain any @author 
tags.
     [exec]     [exec]     +1 tests included.  The patch appears to include 19 
new or modified tests.
     [exec]     [exec]     -1 javadoc.  The javadoc tool appears to have 
generated 1 warning messages.
     [exec]     [exec]     +1 javac.  The applied patch does not increase the 
total number of javac compiler warnings.
     [exec]     [exec]     +1 findbugs.  The patch does not introduce any new 
Findbugs warnings.
     [exec]     [exec]     -1 Eclipse classpath. The patch causes the Eclipse 
classpath to differ from the contents of the lib directories.

     [exec]     

The javadoc and eclipse classpath were failing before this patch.  Once this is 
commited the eclipse classpath check should start showing +1 again.

I manually tested this:
- check out svn tree
- apply patch
- svn rm the empty files
- build eclipse target either from within eclipse or with ant eclipse
- refresh eclipse
- build eclipse project
- everything resolves and you can run unit tests

> Have a way to automatically update Eclipse .classpath file when new libs are 
> added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7248
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7248
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.20.3
>            Reporter: Konstantin Boudnik
>            Assignee: Thomas Graves
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-7248-branch-20-security.patch
>
>
> Backport HADOOP-6407 into 0.20 based source trees

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to