[
https://issues.apache.org/jira/browse/HADOOP-14918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-14918:
------------------------------------
Attachment: HADOOP-14918-001.patch
Patch 001
* cut dependencies & profile from pom
* coverage in testing.md
* all use of the localdynamodb profile in tests
* all imports/use of the lib.
Testing: s3guard, s3guard local, unguarded. All good apart from
ITestS3AFileOperationCost; covered elsewhere.
I had to change {{org.apache.hadoop.fs.s3a.commit.staging.StagingTestBase}} as
method in a mockito interface was missing. {{InvocationTarget.getArgumentAt()}}
turns out to be deprecated and then removed in more recent versions of mockito.
The dynamodb import must have been pulling a version of mockito which had the
method; I'd used the operation in HADOOP-13786, and this removal broke it.
Fixed...but it implies we weren't doing enough diligence on our imports
> remove the Local Dynamo DB test option
> --------------------------------------
>
> Key: HADOOP-14918
> URL: https://issues.apache.org/jira/browse/HADOOP-14918
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.9.0, 3.0.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-14918-001.patch
>
>
> I'm going to propose cutting out the localdynamo test option for s3guard
> * the local DDB JAR is unmaintained/lags the SDK We work with...eventually
> there'll be differences in API.
> * as the local dynamo DB is unshaded. it complicates classpath setup for the
> build. Remove it and there's no need to worry about versions of anything
> other than the shaded AWS
> * it complicates test runs. Now we need to test for both localdynamo *and*
> real dynamo
> * but we can't ignore real dynamo, because that's the one which matters
> While the local option promises to reduce test costs, really, it's just
> adding complexity. If you are testing with s3guard, you need to have a real
> table to test against., And with the exception of those people testing s3a
> against non-AWS, consistent endpoints, everyone should be testing with
> S3Guard.
> Straightforward to remove.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
