[ 
https://issues.apache.org/jira/browse/HADOOP-13171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291545#comment-16291545
 ] 

Steve Loughran commented on HADOOP-13171:
-----------------------------------------

No fundamental reason; they really just evolved so we could see what the read 
performance issues where with seeks& aborts, so the streams.toString() prints 
them. The upload stuff is more collecting useful stuff on a system.  

if you can see value in aggregating them all.: do it.

One thing: the input stream stats aren't collected in the live stream, so 
there's no performance hit of using them; it's only in the close() that they 
get pulled up. For the write stuff (and committer code) everything is done 
through the atomic longs

> Add StorageStatistics to S3A; instrument some more operations
> -------------------------------------------------------------
>
>                 Key: HADOOP-13171
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13171
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 2.8.0, 3.0.0-alpha1
>
>         Attachments: HADOOP-13171-014.patch, HADOOP-13171-016.patch, 
> HADOOP-13171-branch-2-001.patch, HADOOP-13171-branch-2-002.patch, 
> HADOOP-13171-branch-2-003.patch, HADOOP-13171-branch-2-004.patch, 
> HADOOP-13171-branch-2-005.patch, HADOOP-13171-branch-2-006.patch, 
> HADOOP-13171-branch-2-007.patch, HADOOP-13171-branch-2-008.patch, 
> HADOOP-13171-branch-2-009.patch, HADOOP-13171-branch-2-010.patch, 
> HADOOP-13171-branch-2-011.patch, HADOOP-13171-branch-2-012.patch, 
> HADOOP-13171-branch-2-013.patch, HADOOP-13171-branch-2-015.patch, 
> HADOOP-13171-branch-2.8-017.patch
>
>
> Add {{StorageStatistics}} support to S3A, collecting the same metrics as the 
> instrumentation, but sharing across all instances.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to