[
https://issues.apache.org/jira/browse/HADOOP-13974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-13974:
------------------------------------
Resolution: Fixed
Fix Version/s: 3.1.0
Status: Resolved (was: Patch Available)
LGTM,
+1
committed with the checkstyle fixup.
Did some manual testing of the CLI to see how it was usable, by playing with
the commands while {{ITestS3AHugeMagicCommits}} was running trying to list,
expect and then abort uploads. All worked as planned, showing the test fails
when the MPU has gone away.
{code}
[INFO] Running org.apache.hadoop.fs.s3a.commit.magic.ITestS3AHugeMagicCommits
[ERROR] Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 21.326
s <<< FAILURE! - in
org.apache.hadoop.fs.s3a.commit.magic.ITestS3AHugeMagicCommits
[ERROR]
test_030_postCreationAssertions(org.apache.hadoop.fs.s3a.commit.magic.ITestS3AHugeMagicCommits)
Time elapsed: 1.379 s <<< ERROR!
java.io.FileNotFoundException: Completing multipart commit on
tests3ascale/ITestS3AHugeMagicCommits/commit/commit.bin:
com.amazonaws.services.s3.model.AmazonS3Exception: The specified upload does
not exist. The upload ID may be invalid, or the upload may have been aborted or
completed. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchUpload;
Request ID: 1B30AA468F752529; S3 Extended Request ID:
wlnr2JD+Ol6B6y4J6vs+RgXZPjhsq7IY2/C7z4pF+rLtA9P8Q8Yoog5Y4cip8xPuHUWytOAOOvU=),
S3 Extended Request ID:
wlnr2JD+Ol6B6y4J6vs+RgXZPjhsq7IY2/C7z4pF+rLtA9P8Q8Yoog5Y4cip8xPuHUWytOAOOvU=:NoSuchUpload
at
org.apache.hadoop.fs.s3a.commit.magic.ITestS3AHugeMagicCommits.test_030_postCreationAssertions(ITestS3AHugeMagicCommits.java:148)
Caused by: com.amazonaws.services.s3.model.AmazonS3Exception: The specified
upload does not exist. The upload ID may be invalid, or the upload may have
been aborted or completed. (Service: Amazon S3; Status Code: 404; Error Code:
NoSuchUpload; Request ID: 1B30AA468F752529; S3 Extended Request ID:
wlnr2JD+Ol6B6y4J6vs+RgXZPjhsq7IY2/C7z4pF+rLtA9P8Q8Yoog5Y4cip8xPuHUWytOAOOvU=)
at
org.apache.hadoop.fs.s3a.commit.magic.ITestS3AHugeMagicCommits.test_030_postCreationAssertions(ITestS3AHugeMagicCommits.java:148)
{code}
I consider that a success.
> S3Guard CLI to support list/purge of pending multipart commits
> --------------------------------------------------------------
>
> Key: HADOOP-13974
> URL: https://issues.apache.org/jira/browse/HADOOP-13974
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.0.0-beta1
> Reporter: Steve Loughran
> Assignee: Aaron Fabbri
> Fix For: 3.1.0
>
> Attachments: HADOOP-13974.001.patch, HADOOP-13974.002.patch,
> HADOOP-13974.003.patch, HADOOP-13974.004.patch, HADOOP-13974.005.patch,
> HADOOP-13974.006.patch, HADOOP-13974.007.patch
>
>
> The S3A CLI will need to be able to list and delete pending multipart
> commits.
> We can do the cleanup already via fs.s3a properties. The CLI will let scripts
> stat for outstanding data (have a different exit code) and permit batch jobs
> to explicitly trigger cleanups.
> This will become critical with the multipart committer, as there's a
> significantly higher likelihood of commits remaining outstanding.
> We may also want to be able to enumerate/cancel all pending commits in the FS
> tree
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
