[
https://issues.apache.org/jira/browse/HADOOP-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296772#comment-16296772
]
Steve Loughran commented on HADOOP-15128:
-----------------------------------------
We've had problems with RawLocalFileSystem#loadPermissionInfo() being a
performance killer when it execs local fs operations, especially on Windows:
HADOOP-14600.
What is toString being used for?
* If is being logged as the output of operations like {{hadoop fs -ls}} then
we're duty bound by way of the compat guidelines to not break the format of the
output. I believe the patch is safe there, other than the API changes
* If its just being logged in our info/debug strings, calling loadParmissions
is a very expensive operation to undertake in some filesystems, and, as noted,
it can fail. And, because it changes the state of the object, it means that log
statements will have side effects when enabled. I don't want to be in the
situation where logging @ debug makes code work, and turning it off fixes it;
that's the bane of C/C++ debug macros.
Is there a way to do a fix which doesn't force an eval in a normal toString,
but only when needed for logging to the console? I'm sure we've done it with
other classes where we ended up adding a "for console output" toString
equivalent. Though I like fileStatus to stay the same, given its ubiquity
> TestViewFileSystem tests are broken in trunk
> --------------------------------------------
>
> Key: HADOOP-15128
> URL: https://issues.apache.org/jira/browse/HADOOP-15128
> Project: Hadoop Common
> Issue Type: Bug
> Components: viewfs
> Affects Versions: 3.1.0
> Reporter: Anu Engineer
> Assignee: Hanisha Koneru
>
> The fix in Hadoop-10054 seems to have caused a test failure. Please take a
> look. Thanks [~eyang] for reporting this.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
