[
https://issues.apache.org/jira/browse/HADOOP-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301262#comment-16301262
]
Steve Loughran commented on HADOOP-12897:
-----------------------------------------
LGTM.
Two suggested changes::
* in {{wrapExceptionWithMessage}} when you can't get the string constructor,
log the message so it's in the output
* mark {{wrapExceptionWithMessage}} as package/VisibleForTesting, then add some
tests to see how it handles valid IOE and some subclass with no simple string
constructor. Failure code never gets enough coverage, so we should do our best
> KerberosAuthenticator.authenticate to include URL on IO failures
> ----------------------------------------------------------------
>
> Key: HADOOP-12897
> URL: https://issues.apache.org/jira/browse/HADOOP-12897
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Ajay Kumar
> Priority: Minor
> Attachments: HADOOP-12897.001.patch
>
>
> If {{KerberosAuthenticator.authenticate}} can't connect to the endpoint, you
> get a stack trace, but without the URL it is trying to talk to.
> That is: it doesn't have any equivalent of the {{NetUtils.wrapException}}
> handler —which can't be called here as its not in the {{hadoop-auth}} module
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
