[
https://issues.apache.org/jira/browse/HADOOP-15117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306541#comment-16306541
]
Íñigo Goiri commented on HADOOP-15117:
--------------------------------------
In general [^HADOOP-15117.002.patch] looks good.
* In {{AbstractContractPathHandleTest}}, do we need the {{if}} checks in the
catch after 180? We should've made sure those were true before. Are we covering
anything there?
* Can we describe the {{serialize}} in {{TestHDFSContractPathHandle}}? Maybe
move it from {{Boolean}} to {{boolean}} too.
> open(PathHandle) contract test should be exhaustive for default options
> -----------------------------------------------------------------------
>
> Key: HADOOP-15117
> URL: https://issues.apache.org/jira/browse/HADOOP-15117
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Attachments: HADOOP-15117.000.patch, HADOOP-15117.001.patch,
> HADOOP-15117.002.patch
>
>
> The current {{AbstractContractOpenTest}} covers many, but not all of the
> permutations of the default {{HandleOpt}}. It could also be refactored to be
> clearer as documentation
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
