[ 
https://issues.apache.org/jira/browse/HADOOP-15149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306806#comment-16306806
 ] 

Steve Loughran commented on HADOOP-15149:
-----------------------------------------

Moot as the patch is in, but it'd have been cleaner for the asserts to have 
been one in a assertCapability(key, StreamCapabilities subject, bool outcome) 
and had it throw meaningful exceptions on a failure

> CryptoOutputStream should implement StreamCapabilities
> ------------------------------------------------------
>
>                 Key: HADOOP-15149
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15149
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: fs
>    Affects Versions: 3.0.0
>            Reporter: Mike Drob
>            Assignee: Xiao Chen
>             Fix For: 3.1.0, 2.10.0, 2.9.1, 3.0.1
>
>         Attachments: HADOOP-15149.01.patch
>
>
> Running some tests with HBase on HDFS with encryption, we noticed that 
> CryptoOutputStream doesn't implement StreamCapabilities.
> Specifically, we have a HdfsDataOutputStream wrapping a CryptoOutputStream. 
> The calls to {{hasCapability}} on the HDOS will always return false, even 
> though the COS could be wrapping something that supports it, as evidenced by 
> the implementation of hsync and hflush here.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to