[
https://issues.apache.org/jira/browse/HADOOP-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308315#comment-16308315
]
Jason Lowe commented on HADOOP-15147:
-------------------------------------
{{finish}} and {{finished}} are different boolean variables. I agree the
naming is not stellar, but I do not believe there's a redundant check in the
boolean expression here.
> SnappyCompressor Typo
> ---------------------
>
> Key: HADOOP-15147
> URL: https://issues.apache.org/jira/browse/HADOOP-15147
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 3.0.0
> Reporter: BELUGA BEHR
> Priority: Trivial
>
> {code:title=SnappyCompressor.java}
> public boolean finished() {
> // Check if all uncompressed data has been consumed
> return (finish && finished && compressedDirectBuf.remaining() == 0);
> }
> {code}
> Notice "finish" is checked twice
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
