[
https://issues.apache.org/jira/browse/HADOOP-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324505#comment-16324505
]
Rushabh S Shah commented on HADOOP-15169:
-----------------------------------------
I am not an expert in HttpServer area so please let me know if some of my
comments doesn't make sense.
Overall the change looks good.
Have few comments.
+SslSelectChannelConnectorSecure.java+
* The list of enabled protocols from SSLEngine are {{SSLv2Hello, TLSv1,
TLSv1.1, TLSv1.2}}.
After the change, we will filter out {{SSLv2Hello}}.
I think it should be ok.
* {quote}
+ private boolean contains(String p, String[] c) {
{quote}
Would be nice to use human readable variables instead of p and c.
Also it would be nice to have some supporting test cases.
> "hadoop.ssl.enabled.protocols" should be considered in httpserver2
> ------------------------------------------------------------------
>
> Key: HADOOP-15169
> URL: https://issues.apache.org/jira/browse/HADOOP-15169
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-15169-branch-2.patch, HADOOP-15169.patch
>
>
> As of now *hadoop.ssl.enabled.protocols"* will not take effect for all the
> http servers( only Datanodehttp server will use this config).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
