[
https://issues.apache.org/jira/browse/HADOOP-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324680#comment-16324680
]
Wangda Tan commented on HADOOP-15009:
-------------------------------------
[~subru], could you help to take a look at the patch since you reviewed
resourceestimator original implementation before?
> hadoop-resourceestimator's shell scripts are a mess
> ---------------------------------------------------
>
> Key: HADOOP-15009
> URL: https://issues.apache.org/jira/browse/HADOOP-15009
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts, tools
> Affects Versions: 3.1.0
> Reporter: Allen Wittenauer
> Assignee: Ajay Kumar
> Priority: Blocker
> Attachments: HADOOP-15009.001.patch, Screen Shot 2017-12-12 at
> 11.16.23 AM.png
>
>
> #1:
> There's no reason for estimator.sh to exist. Just make it a subcommand under
> yarn or whatever.
> #2:
> In it's current form, it's missing a BUNCH of boilerplate that makes certain
> functionality completely fail.
> #3
> start/stop-estimator.sh is full of copypasta that doesn't actually do
> anything/work correctly. Additionally, if estimator.sh doesn't exist,
> neither does this since yarn --daemon start/stop will do everything as
> necessary.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
