[
https://issues.apache.org/jira/browse/HADOOP-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341831#comment-16341831
]
Jason Lowe commented on HADOOP-15170:
-------------------------------------
Thanks for the patch! Apologies for the delay.
The VisibleForTesting import looks shady (pun intended). We should be pulling
this in from the normal location. Actually even better would be to simply make
this package-private rather than public. Then I would argue the visibility
marker isn't necessary.
The createSymbolicLinkUsingJava does not seem worth it given it's private and
it's less typing to call the Files method directly.
> Add symlink support to FileUtil#unTarUsingJava
> -----------------------------------------------
>
> Key: HADOOP-15170
> URL: https://issues.apache.org/jira/browse/HADOOP-15170
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Reporter: Jason Lowe
> Assignee: Ajay Kumar
> Priority: Minor
> Attachments: HADOOP-15170.001.patch, HADOOP-15170.002.patch
>
>
> Now that JDK7 or later is required, we can leverage
> java.nio.Files.createSymbolicLink in FileUtil.unTarUsingJava to support
> archives that contain symbolic links.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
