[ 
https://issues.apache.org/jira/browse/HADOOP-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364660#comment-16364660
 ] 

Steve Loughran commented on HADOOP-14734:
-----------------------------------------

you've changed the line, it's picked up on an existing issue. The existing 
method shouldn't have done it. Change the param name to something else to make 
this go away, e.g "config"

* revert field dynamoDBDocumentClient to dynamoDB; reduces change elsewhere, 
cost of merging other patches, etc.
* I don't see where tagTable is being called.

tests:
*  check the ordering of imports.
* test needs to skip when
* we are going to have to move off the TestMetadataStore altogether (see other 
JIRAs). Is this going to make that harder? Or, if we already have moved to an 
ITest only, make this test easier as a single method



> add option to tag DDB table(s) created
> --------------------------------------
>
>                 Key: HADOOP-14734
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14734
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.0.0-beta1
>            Reporter: Steve Loughran
>            Assignee: Abraham Fine
>            Priority: Minor
>         Attachments: HADOOP-14734-001.patch, HADOOP-14734-002.patch
>
>
> Many organisations have a "no untagged" resource policy; s3guard runs into 
> this when a table is created untagged. If there's a strict "delete untagged 
> resources" policy, the tables will go without warning.
> Proposed: we add an option which can be used to declare the tags for a table 
> when created, use it in creation. No need to worry about updating/viewing 
> tags, as the AWS console can do that



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to