[
https://issues.apache.org/jira/browse/HADOOP-14396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HADOOP-14396:
-----------------------------------
Status: Patch Available (was: Open)
Updated the patch to address reviews:
bq. FSDataOutputStreamBuilder line 79: fs = null when built from file context.
Later in getFS() there is Preconditions.checkNotNull(fs); So, the expectation
is no one should be calling getFS() when it is constructed from FileContext ?
If using {{FileContext}}, the fs field is not used. Yes, no one should call
{{getFS()}} if it is constructed from FileContext.
bq. Why do we need an additional "donotCreateParent" option?
It is not necessary indeed. Removed in the new patch.
bq. Can you please extend the test with few build() options like recursive /
progress added ?
Done
bq. There is an annotation @Nonnull FileContext fc and also later
Preconditions.checkNotNull(fc); Is the later needed in the constructor?
My understand is that @Nonnull is for compile time check, but Precondition is
for runtime check. Giving this is a public API, it prevents other call hdfs
client as library.
> Add builder interface to FileContext
> ------------------------------------
>
> Key: HADOOP-14396
> URL: https://issues.apache.org/jira/browse/HADOOP-14396
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 3.0.0-alpha3, 2.9.0
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Priority: Major
> Attachments: HADOOP-14396.00.patch, HADOOP-14396.01.patch
>
>
> Add builder interface for {{FileContext#create}} and {{FileContext#append}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
