Zsolt Venczel commented on HADOOP-15252:

While I agree on such an upgrade IDEA checkstyle plugin can handle old version 
by explicitly providing the version number:  !idea_checkstyle_settings.png!

There is one odd behavior we noticed with IDEA though: due to some caching 
issue you should set the Checkstyle version then hit OK, reopen settings then 
add the config file.

> Checkstyle version is not compatible with IDEA's checkstyle plugin
> ------------------------------------------------------------------
>                 Key: HADOOP-15252
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15252
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Andras Bokor
>            Assignee: Andras Bokor
>            Priority: Major
>         Attachments: HADOOP-15252.001.patch, idea_checkstyle_settings.png
> After upgrading to the latest IDEA the IDE throws error messages in every few 
> minutes like
> {code:java}
> The Checkstyle rules file could not be parsed.
> SuppressionCommentFilter is not allowed as a child in Checker
> The file has been blacklisted for 60s.{code}
> This is caused by some backward incompatible changes in checkstyle source 
> code:
>  [http://checkstyle.sourceforge.net/releasenotes.html]
>  * 8.1: Make SuppressionCommentFilter and SuppressWithNearbyCommentFilter 
> children of TreeWalker.
>  * 8.2: remove FileContentsHolder module as FileContents object is available 
> for filters on TreeWalker in TreeWalkerAudit Event.
> IDEA uses checkstyle 8.8
> We should upgrade our checkstyle version to be compatible with IDEA's 
> checkstyle plugin.
>  Also it's a good time to upgrade maven-checkstyle-plugin as well to brand 
> new 3.0.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to