[
https://issues.apache.org/jira/browse/HADOOP-15253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405657#comment-16405657
]
Konstantin Shvachko commented on HADOOP-15253:
----------------------------------------------
The change looks good to me. Minor things for the unit test:
# import of {{DFSConfigKeys}} is redundant.
# Would be better to incorporate the check of the queue size change into
{{testRefresh()}} instead of creating a new test case. That way the test will
not start up mini cluster one more time, will run faster.
> Should update maxQueueSize when refresh call queue
> --------------------------------------------------
>
> Key: HADOOP-15253
> URL: https://issues.apache.org/jira/browse/HADOOP-15253
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.8.2
> Reporter: Tao Jie
> Assignee: Tao Jie
> Priority: Minor
> Attachments: HADOOP-15253.001.patch, HADOOP-15253.002.patch
>
>
> When calling {{dfsadmin -refreshCallQueue}} to update CallQueue instance,
> {{maxQueueSize}} should also be updated.
> In case of changing CallQueue instance to FairCallQueue, the length of each
> queue in FairCallQueue would be 1/priorityLevels of original length of
> DefaultCallQueue. So it would be helpful for us to set the length of
> callqueue to a proper value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
