[ https://issues.apache.org/jira/browse/HADOOP-6897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409688#comment-16409688 ]
genericqa commented on HADOOP-6897: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color} | {color:red} HADOOP-6897 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HADOOP-6897 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12451172/mkdirs.patch | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/14372/console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > FileSystem#mkdirs(FileSystem, Path, FsPermission) should not call > setPermission if mkdirs failled > ------------------------------------------------------------------------------------------------- > > Key: HADOOP-6897 > URL: https://issues.apache.org/jira/browse/HADOOP-6897 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 0.22.0 > Reporter: Hairong Kuang > Assignee: Hairong Kuang > Priority: Major > Attachments: mkdirs.patch > > > Here is the piece of code that has the bug. fs.setPermission should not be > called if result is false. > {code} > public static boolean mkdirs(FileSystem fs, Path dir, FsPermission > permission) > throws IOException { > // create the directory using the default permission > boolean result = fs.mkdirs(dir); > // set its permission to be the supplied one > fs.setPermission(dir, permission); > return result; > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org