[
https://issues.apache.org/jira/browse/HADOOP-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035548#comment-13035548
]
Hadoop QA commented on HADOOP-7300:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479625/hadoop-7300.txt
against trunk revision 1104426.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/469//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/469//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/469//console
This message is automatically generated.
> Configuration methods that return collections are inconsistent about
> mutability
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7300
> URL: https://issues.apache.org/jira/browse/HADOOP-7300
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7300.txt
>
>
> In particular, getTrimmedStringCollection seems to return an immutable
> collection, whereas getStringCollection returns a mutable one.
> IMO we should always return mutable collections since these methods by
> definition are doing copies.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
