[
https://issues.apache.org/jira/browse/HADOOP-15339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412226#comment-16412226
]
Xiaoyu Yao commented on HADOOP-15339:
-------------------------------------
Thanks [~elek] for reporting the issue and posting the fix. The patch looks
good to me. Just one suggestion:
MBeans.java
Line 55: unused empty private constructor, can we remove it?
Line 90: can we add a precondition check to ensure properties map is not null
as getMBeanName cannot handle that.
> Support additional key/value propereties in JMX bean registration
> -----------------------------------------------------------------
>
> Key: HADOOP-15339
> URL: https://issues.apache.org/jira/browse/HADOOP-15339
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Attachments: HADOOP-15339.001.patch, HADOOP-15339.002.patch
>
>
> org.apache.hadoop.metrics2.util.MBeans.register is a utility function to
> register objects to the JMX registry with a given name prefix and name.
> JMX supports any additional key value pairs which could be part the the
> address of the jmx bean. For example:
> _java.lang:type=MemoryManager,name=CodeCacheManager_
> Using this method we can query a group of mbeans, for example we can add the
> same tag to similar mbeans from namenode and datanode.
> This patch adds a small modification to support custom key value pairs and
> also introduce a new unit test for MBeans utility which was missing until now.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
