[ 
https://issues.apache.org/jira/browse/HADOOP-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427582#comment-16427582
 ] 

Xiao Chen commented on HADOOP-15344:
------------------------------------

Thanks [~zhenyi] for working on this and [~shahrs87] for the thoughts.

{quote}but {{renew}} will throw an Exception in finally block which will fail 
the renew operation.
{quote}
Could you elaborate? If one of the KMSCP inside LBKMSCP succeeds, LBKMSCP#doOp 
will return. The exception from the failure is just logged and won't be thrown 
out.

Regarding close, if any of the close failed, I think it makes sense to throw, 
the same way as if in a close method of a class, if any sub resources failed to 
close, the class' close should throw, right? So I think your initial propose 
makes sense, and we should throw on close failures

> LoadBalancingKMSClientProvider#close should not swallow exceptions
> ------------------------------------------------------------------
>
>                 Key: HADOOP-15344
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15344
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: kms
>            Reporter: Xiao Chen
>            Assignee: fang zhenyi
>            Priority: Minor
>         Attachments: HADOOP-15344.001.patch
>
>
> As [~shahrs87]'s comment on HADOOP-14445 says:
> {quote}
> LoadBalancingKMSCP never throws IOException back. It just swallows all the 
> IOException and just logs it.
> ...
> Maybe we might want to return MultipleIOException from 
> LoadBalancingKMSCP#close. 
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to