Ajay Kumar commented on HADOOP-15362:

Hi [~belugabehr], patch v5 changes access for Resource constructors to package 
default. Is this intentional? I think orignal purpose of this was to allow 
client to add external resources as required. Changing its access level to 
default will restrict that. Similarly getWarningMessage is declared final and 
patch v5 changes it.

> Review of Configuration.java
> ----------------------------
>                 Key: HADOOP-15362
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15362
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HADOOP-15362.1.patch, HADOOP-15362.2.patch, 
> HADOOP-15362.3.patch, HADOOP-15362.4.patch, HADOOP-15362.5.patch
> * Various improvements
>  * Fix a lot of checks style errors
> When I ran a recent debug log against a MR job, I was spammed from the 
> following messages.  I ask that we move them to 'trace' as there is already a 
> debug level logging preceding them.
> {code:java}
> LOG.debug("Handling deprecation for all properties in config");
> foreach item {
> -      LOG.debug("Handling deprecation for " + (String)item);
> +      LOG.trace("Handling deprecation for {}", item);
> }{code}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to