[
https://issues.apache.org/jira/browse/HADOOP-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442652#comment-16442652
]
Steve Loughran commented on HADOOP-15392:
-----------------------------------------
This isn't good.
Looking @ the patch, the system is being shutdown & deleted when
S3AInstrumentation.close() is called, and that is invoked when
S3AFileSystem.close() is called.
If only one instance in an FS is cached, then memory use is a problem if this
metrics instance is storing lots and lots of stuff without cleanup.
When the #of closed FS instances == 0, then the metrics system should be shut
down (it's ref counted). If the fs.close() methods aren't being invoked, we
could end up with the instances continuing being registered. Otherwise, maybe
the cached entries aren't being cleaned up.
Thoughts: [~fabbri] [~iyonger] [~sean_impala_9b93]?
[[email protected]] Ted: can you point me at HBase the code here? I'd like to
see what it's doing.
> S3A Metrics in S3AInstrumentation Cause Memory Leaks
> ----------------------------------------------------
>
> Key: HADOOP-15392
> URL: https://issues.apache.org/jira/browse/HADOOP-15392
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.1.0
> Reporter: Voyta
> Priority: Major
>
> While using HBase S3A Export Snapshot utility we started to experience memory
> leaks of the process after version upgrade.
> By running code analysis we traced the cause to revision
> 6555af81a26b0b72ec3bee7034e01f5bd84b1564 that added the following static
> reference (singleton):
> private static MetricsSystem metricsSystem = null;
> When application uses S3AFileSystem instance that is not closed immediately
> metrics are accumulated in this instance and memory grows without any limit.
>
> Expectation:
> * It would be nice to have an option to disable metrics completely as this
> is not needed for Export Snapshot utility.
> * Usage of S3AFileSystem should not contain any static object that can grow
> indefinitely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
