[ 
https://issues.apache.org/jira/browse/HADOOP-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036600#comment-13036600
 ] 

Hadoop QA commented on HADOOP-7306:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12479806/hadoop-7306-missing-conf-v1.patch
  against trunk revision 1125051.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: 
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/487//testReport/
Findbugs warnings: 
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/487//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/487//console

This message is automatically generated.

> Start metrics system even if config files are missing
> -----------------------------------------------------
>
>                 Key: HADOOP-7306
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7306
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.23.0
>            Reporter: Luke Lu
>            Assignee: Luke Lu
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7306-missing-conf-v1.patch
>
>
> Per experience and discussion with HDFS-1922, it seems preferable to treat 
> missing metrics config file as empty/default config, which is more compatible 
> with metrics v1 behavior (the MBeans are always registered.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to