[ 
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462994#comment-16462994
 ] 

Sean Mackrory edited comment on HADOOP-15356 at 5/3/18 8:14 PM:
----------------------------------------------------------------

Addressing the findbugs and checkstyle complaints. The test failure is simply 
because the test requires an actual FS instance to get at the SDK and interact 
with it, so now I assume that the FS is not null. I tested the test is 
gracefully skipped without configuration and passes with configuration. Being a 
little less familiar with the way we intend to differentiate between true unit 
tests and integration tests in ADLS than how we do it in S3A, perhaps I'm 
missing a more idiomatic way to do it. But it seems most other tests are just 
using the contract tests enabled flag, which doesn't seem appropriate for use 
here. Ran Yetus locally and see no really problems with the patch - but the 
compile step is missing some dependencies I need to chase down and usually 
checkstyle seems be more lenient on my machine for some reason. Re-ran tests 
against East US 2, though.


was (Author: mackrorysd):
Addressing the findbugs and checkstyle complaints. The test failure is simply 
because the test requires an actual FS instance to get at the SDK and interact 
with it, so now I assume that the FS is not null. Being a little less familiar 
with the way we intend to differentiate between true unit tests and integration 
tests in ADLS than how we do it in S3A, perhaps I'm missing a more idiomatic 
way to do it. But it seems most other tests are just using the contract tests 
enabled flag, which doesn't seem appropriate for use here. Ran Yetus locally 
and see no really problems with the patch - but the compile step is missing 
some dependencies I need to chase down and usually checkstyle seems be more 
lenient on my machine for some reason. Re-ran tests against East US 2, though.

> Make HTTP timeout configurable in ADLS Connector
> ------------------------------------------------
>
>                 Key: HADOOP-15356
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15356
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/adl
>            Reporter: Atul Sikaria
>            Assignee: Atul Sikaria
>            Priority: Major
>         Attachments: HADOOP-15356.001.patch, HADOOP-15356.002.patch, 
> HADOOP-15356.003.patch, HADOOP-15356.004.patch
>
>
> Currently the HTTP timeout for the connections to ADLS are not configurable 
> in Hadoop. This patch enables the timeouts to be configurable based on a 
> core-site config setting. Also, up the ADLS SDK version to 2.2.8, that has 
> default value of 60 seconds - any optimizations to that setting can now be 
> done in Hadoop through core-site.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to