[ 
https://issues.apache.org/jira/browse/HADOOP-13649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466798#comment-16466798
 ] 

Aaron Fabbri edited comment on HADOOP-13649 at 5/8/18 3:07 AM:
---------------------------------------------------------------

Nice work [~gabor.bota], this looks good. I hope you don't mind, I've attached 
a v3 of the patch with a couple tweaks:

- Fix the checkstyle issue.
- TTL is optional (if ttl config is zero, it is disabled)
- TTL units seconds -> milliseconds (in case anyone wants to play with very 
short TTLs, which i think are interesting)
- Minor test changes to make sure they still work with zero TTL
- Added "Evolving" API annotations to the "undocumented" configs used for 
LocalMetadataStore.

Please review and give a "+1 (nonbinding)" if you like these changes.  I tested 
in US West 2.


was (Author: fabbri):
Nice work [~gabor.bota], this looks good. I hope you don't mind, I've attached 
a v3 of the patch with a couple tweaks:

- Fix the checkstyle issue.
- TTL is optional (if ttl config is zero, it is disabled)
- TTL units seconds -> milliseconds (in case anyone wants to play with very 
short TTLs, which i think are interesting)
- Minor test changes to make sure they still work with zero TTL

Please review and give a "+1 (nonbinding)" if you like these changes.  I tested 
in US West 2.

> s3guard: implement time-based (TTL) expiry for LocalMetadataStore
> -----------------------------------------------------------------
>
>                 Key: HADOOP-13649
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13649
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.0.0-beta1
>            Reporter: Aaron Fabbri
>            Assignee: Gabor Bota
>            Priority: Minor
>         Attachments: HADOOP-13649.001.patch, HADOOP-13649.002.patch, 
> HADOOP-13649.003.patch
>
>
> LocalMetadataStore is primarily a reference implementation for testing.  It 
> may be useful in narrow circumstances where the workload can tolerate 
> short-term lack of inter-node consistency:  Being in-memory, one JVM/node's 
> LocalMetadataStore will not see another node's changes to the underlying 
> filesystem.
> To put a bound on the time during which this inconsistency may occur, we 
> should implement time-based (a.k.a. Time To Live / TTL)  expiration for 
> LocalMetadataStore



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to