[ 
https://issues.apache.org/jira/browse/HADOOP-7318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037687#comment-13037687
 ] 

Hadoop QA commented on HADOOP-7318:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12480018/hadoop-7318.txt
  against trunk revision 1125221.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: 
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/503//testReport/
Findbugs warnings: 
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/503//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/503//console

This message is automatically generated.

> MD5Hash factory should reset the digester it returns
> ----------------------------------------------------
>
>                 Key: HADOOP-7318
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7318
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>             Fix For: 0.22.0
>
>         Attachments: hadoop-7318.txt, hadoop-7318.txt
>
>
> Currently the getDigest() method in MD5Hash does not reset the digester it 
> returns. Since it's a thread-local, this means that a previous aborted usage 
> of the same digester could leave some state around. For example, if the 
> secondary namenode receives an IOException while transfering the image, and 
> does another image transfer with the same thread, it will think it has 
> received an invalid digest.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to