[ 
https://issues.apache.org/jira/browse/HADOOP-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475979#comment-16475979
 ] 

Steve Loughran commented on HADOOP-15442:
-----------------------------------------

+1

> ITestS3AMetrics.testMetricsRegister can't know metrics source's name
> --------------------------------------------------------------------
>
>                 Key: HADOOP-15442
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15442
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>            Priority: Major
>         Attachments: HADOOP-15442.001.patch
>
>
> I've seen this test fail a bunch lately - mainly when the tests are all run 
> (i.e. not individually) but not in parallel, it seems. If you dump out the 
> sources when it fails, you see:
> * The sources are numbered in the hundreds, so it's very unlikely that this 
> actually gets the first one.
> * The sources are numbered twice. There was logic to have the first one not 
> be numbered, but that got messed up and now all sources are numbered twice, 
> but the first one is only number once.
> We could just remove the bad assertion, but then we're only testing the 
> registry and not anything else about the way metrics flow all the way through 
> the whole system. Worth it to fix the failing test, I think - knowing the 
> source gets registered doesn't add a whole lot of value toward end-to-end 
> metrics testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to