Steve Loughran commented on HADOOP-15430:

*  I'll look at the comment and cleanup

bq. This part, I'm assuming is for the trailing double slash case, right?

I worry now that this is superfluous with the previous code. And you need to 
handle "////", don't you? Stripping all is better.

I think the part you are asking about is from my first fix attempt; then I just 
copied in the stuff from the Path code.

Let me review this and see if those tests failures are actually independent of 
this code by switching branches & seeing how isolated they are.

I'll consider your +1 on hold...

> hadoop fs -mkdir -p path-ending-with-slash/ fails with s3guard
> --------------------------------------------------------------
>                 Key: HADOOP-15430
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15430
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.1.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Blocker
>         Attachments: HADOOP-15430-001.patch, HADOOP-15430-002.patch, 
> HADOOP-15430-003.patch
> if you call {{hadoop fs -mkdir -p path/}} on the command line with a path 
> ending in "/:. you get a DDB error "An AttributeValue may not contain an 
> empty string"

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to