[ 
https://issues.apache.org/jira/browse/HADOOP-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479578#comment-16479578
 ] 

Nanda kumar edited comment on HADOOP-15474 at 5/17/18 7:16 PM:
---------------------------------------------------------------

Thanks [~zvenczel] for taking care of this.
The patch looks good to me, a minor comment in {{core-default.xml}}:
 * Can you also fix the typo in line 3038 & 3047: {{DEPRICATED}} --> 
{{DEPRECATED}}


was (Author: nandakumar131):
Thanks [~zvenczel] for taking care of this.
The patch looks good to me, a minor comment:
 * Can you also fix the typo in line 3038 & 3047: {{DEPRICATED}} --> 
{{DEPRECATED}}

> Rename properties introduced for <tags>
> ---------------------------------------
>
>                 Key: HADOOP-15474
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15474
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 3.1.0
>            Reporter: Nanda kumar
>            Assignee: Zsolt Venczel
>            Priority: Major
>         Attachments: HADOOP-15474.01.patch
>
>
> HADOOP-15007 introduces the following two properties for tagging 
> configuration properties
> * hadoop.system.tags
> * hadoop.custom.tags
> This sounds like {{tags}} fall under {{hadoop.system}} and {{hadoop.custom}} 
> related properties, but what we really want to achieve here is to have two 
> sub-division of {{tags}} namely {{system}} and {{custom}}
> For better readability, we can rename them as
> * hadoop.tags.system
> * hadoop.tags.custom



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to