[ 
https://issues.apache.org/jira/browse/HADOOP-15458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489309#comment-16489309
 ] 

Íñigo Goiri commented on HADOOP-15458:
--------------------------------------

{quote}
The stream.close() should be called even if the assertions are raised. 
try-with-resources can do this easily enough
{quote}

True, that's basically the kind of error we've been fixing for Windows.
We want to put this all the way back to branch-2.9, I think branch-2.9 already 
has the Java support for the try syntax.
[~surmountian] can you check the try approach with branch-2.9?
Otherwise, we would need a patch with finally for branch-2.

> org.apache.hadoop.fs.TestLocalFileSystem#testFSOutputStreamBuilder fails on 
> Windows
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-15458
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15458
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Xiao Liang
>            Assignee: Xiao Liang
>            Priority: Major
>              Labels: windows
>         Attachments: HADOOP-15458-branch-2.000.patch, 
> HADOOP-15458-branch-2.001.patch, HADOOP-15458.000.patch, 
> HADOOP-15458.001.patch
>
>
> In *org.apache.hadoop.fs.TestLocalFileSystem#testFSOutputStreamBuilder* a 
> FSDataOutputStream object is unnecessarily created and not closed, which 
> makes org.apache.hadoop.fs.TestLocalFileSystem#after fails to delete the 
> folder on Windows.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to