[
https://issues.apache.org/jira/browse/HADOOP-15480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491473#comment-16491473
]
Aaron Fabbri edited comment on HADOOP-15480 at 5/26/18 2:38 AM:
----------------------------------------------------------------
thanks for the update [~gabor.bota], good work. Tests pass for me in us-west-2.
A couple of minor issues, which I fixed in the v3 patch I'm posting:
# Need to close the new S3AFileSystem
# In the mkdirs() and createFile() helper functions, they will write to
MetadataStore (MS) twice: once through the S3AFileSystem (it updates MS), and
again explicitly to the MS (this is an existing issue).
and then I could not resist cleaning up another issue: The test was allocating
a separate MetadataStore instance from the one already in the S3AFileSystem.
This made the helper-function new code fail with LocalMetadataStore since there
were two different instances of it. So I changed these S3Guard Tool tests to
just get their MetadataStore from the S3AFileSystem under test instead of
creating a separate one.
was (Author: fabbri):
thanks for the update [~gabor.bota], good work. Tests pass for me in us-west-2.
A couple of minor issues, which I fixed in the v3 patch I'm posting:
# Need to close the new S3AFileSystem
# In the mkdirs() and createFile() helper functions, they will write to
MetadataStore (MS) twice: once through the S3AFileSystem (it updates MS), and
again explicitly to the MS.
and then I could not resist cleaning up another issue: The test was allocating
a separate MetadataStore instance from the one already in the S3AFileSystem.
This made the helper-function new code fail with LocalMetadataStore since there
were two different instances of it. So I changed these S3Guard Tool tests to
just get their MetadataStore from the S3AFileSystem under test instead of
creating a separate one.
> AbstractS3GuardToolTestBase.testDiffCommand fails when using dynamo
> -------------------------------------------------------------------
>
> Key: HADOOP-15480
> URL: https://issues.apache.org/jira/browse/HADOOP-15480
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.1.0
> Reporter: Gabor Bota
> Assignee: Gabor Bota
> Priority: Major
> Attachments: HADOOP-15480.001.patch, HADOOP-15480.002.patch,
> HADOOP-15480.003.patch
>
>
> When running org.apache.hadoop.fs.s3a.s3guard.ITestS3GuardToolDynamoDB, the
> testDiffCommand test fails with the following:
> {noformat}
> testDiffCommand(org.apache.hadoop.fs.s3a.s3guard.ITestS3GuardToolDynamoDB)
> Time elapsed: 8.059 s <<< FAILURE!
> java.lang.AssertionError:
> Mismatched metadata store outputs: MS D 0
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only
> MS F 100
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-0
> MS F 100
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-1
> MS F 100
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-3
> MS F 100
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-2
> MS F 100
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-4
> S3 F 0
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-1
> MS F 0
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-1
> S3 F 0
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-0
> MS F 0
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-0
> S3 F 0
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-2
> MS F 0
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-2
> S3 F 0
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-3
> MS F 0
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-3
> S3 F 0
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-4
> MS F 0
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-4
> expected:<[
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-0,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-1,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-3,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-2,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-4]>
> but was:<[
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-1,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-0,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-0,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-1,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-3,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-2,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-2,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-3,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/ms_only/file-4,
> s3a://cloudera-dev-gabor-ireland/test/test-diff/s3_only/file-4]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at
> org.apache.hadoop.fs.s3a.s3guard.AbstractS3GuardToolTestBase.testDiffCommand(AbstractS3GuardToolTestBase.java:382)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at
> org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
