[ 
https://issues.apache.org/jira/browse/HADOOP-15513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501196#comment-16501196
 ] 

Íñigo Goiri commented on HADOOP-15513:
--------------------------------------

Regarding  [^HADOOP-15513.v1.patch], I have one high level comment.
Not all the things tested here are errors right now (e.g., case 3).
We may want to split testSymlinkErrorCases into 5 test cases (e.g., 
testSymLinkAlreadyExists()).
Then we can add the full description of each test in each javadoc function.
We should also put these tests right after the symlink tests and not in the end.

> Add additional test cases to cover some corner cases for FileUtil#symlink
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-15513
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15513
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Giovanni Matteo Fumarola
>            Priority: Major
>         Attachments: HADOOP-15513.v1.patch
>
>
> Add additional test cases to cover some corner cases for FileUtil#symlink.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to