[
https://issues.apache.org/jira/browse/HADOOP-14199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502214#comment-16502214
]
Íñigo Goiri commented on HADOOP-14199:
--------------------------------------
In [^HADOOP-15496.000.patch], by making bs="" in Windows we are just not
testing anything.
This would be equivalent to just test a regular path (no special characters) in
Windows.
Given that, I would just skip the creation of the first and third file in
Windows:
{code}
createFile(new Path(testRootDir, "ghi"));
if (!Shell.WINDOWS) {
createFile(new Path(testRootDir, "abc\bd\tef"));
createFile(new Path(testRootDir, "qq\r123"));
}
{code}
Would be equivalent to what we are doing in [^HADOOP-15496.000.patch].
We can add a comment and say that Windows does not support such characters.
Ideally we would do a test that tests the Windows special characters but I'm
fine with this.
> TestFsShellList.testList fails on windows: illegal filenames
> ------------------------------------------------------------
>
> Key: HADOOP-14199
> URL: https://issues.apache.org/jira/browse/HADOOP-14199
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: test
> Affects Versions: 2.8.0
> Environment: win64
> Reporter: Steve Loughran
> Assignee: Anbang Hu
> Priority: Minor
> Attachments: HADOOP-15496.000.patch
>
>
> {{TestFsShellList.testList}} fails setting up the files to test against
> {code}
> org.apache.hadoop.io.nativeio.NativeIOException: The filename, directory
> name, or volume label syntax is incorrect.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
