[ https://issues.apache.org/jira/browse/HADOOP-15529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508965#comment-16508965 ]
Íñigo Goiri commented on HADOOP-15529: -------------------------------------- I agree with the fix in [^HADOOP-15529.v1.patch]. Can we make the ternary operator a full if? It is easier to read that way. The unit tests are failing on Windows in the daily build too: [here|https://builds.apache.org/job/hadoop-trunk-win/494/testReport/org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher/TestContainerLaunch/]. I would also make this part of HADOOP-15475. > ContainerLaunch#testInvalidEnvVariableSubstitutionType is not supported in > Windows > ---------------------------------------------------------------------------------- > > Key: HADOOP-15529 > URL: https://issues.apache.org/jira/browse/HADOOP-15529 > Project: Hadoop Common > Issue Type: Sub-task > Reporter: Giovanni Matteo Fumarola > Assignee: Giovanni Matteo Fumarola > Priority: Minor > Attachments: HADOOP-15529.v1.patch > > > YARN-5219 introduced 2 unit tests designed for Unix. They currently failing > in Windows. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org