[
https://issues.apache.org/jira/browse/HADOOP-14918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513492#comment-16513492
]
Gabor Bota edited comment on HADOOP-14918 at 6/15/18 7:47 AM:
--------------------------------------------------------------
Thanks for the review [~mackrorysd]!
We need a separate fs.s3a.s3guard.ddb.test.table because
fs.s3a.s3guard.ddb.table will be used by other tests, and we want to avoid
clearing or destroying that table. That was really an intent in my latest patch
- to avoid touching the main table by adding a testing table variable. That way
we can run these tests parallelly with others.
Maybe this need to be documented better?
I'll fix the other three issues, and submit another patch soon.
was (Author: gabor.bota):
Thanks for the review [~mackrorysd]!
We need a separate fs.s3a.s3guard.ddb.test.table because
fs.s3a.s3guard.ddb.table will be used by other tests, and we want to avoid
clearing or destroying that table. That was really an intent in my latest patch
- to avoid touching the main table by adding a testing table variable. That way
we can run these tests parallelly with others.
I'll fix the other three issues, and submit another patch soon.
> Remove the Local Dynamo DB test option
> --------------------------------------
>
> Key: HADOOP-14918
> URL: https://issues.apache.org/jira/browse/HADOOP-14918
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.9.0, 3.0.0
> Reporter: Steve Loughran
> Assignee: Gabor Bota
> Priority: Major
> Attachments: HADOOP-14918-001.patch, HADOOP-14918-002.patch,
> HADOOP-14918-003.patch, HADOOP-14918-004.patch, HADOOP-14918.005.patch
>
>
> I'm going to propose cutting out the localdynamo test option for s3guard
> * the local DDB JAR is unmaintained/lags the SDK We work with...eventually
> there'll be differences in API.
> * as the local dynamo DB is unshaded. it complicates classpath setup for the
> build. Remove it and there's no need to worry about versions of anything
> other than the shaded AWS
> * it complicates test runs. Now we need to test for both localdynamo *and*
> real dynamo
> * but we can't ignore real dynamo, because that's the one which matters
> While the local option promises to reduce test costs, really, it's just
> adding complexity. If you are testing with s3guard, you need to have a real
> table to test against., And with the exception of those people testing s3a
> against non-AWS, consistent endpoints, everyone should be testing with
> S3Guard.
> -Straightforward to remove.-
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
