[
https://issues.apache.org/jira/browse/HADOOP-7322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039009#comment-13039009
]
Hadoop QA commented on HADOOP-7322:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480373/HADOOP-7322-3.patch
against trunk revision 1127215.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/523//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/523//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/523//console
This message is automatically generated.
> Adding a util method in FileUtil for directory listing
> ------------------------------------------------------
>
> Key: HADOOP-7322
> URL: https://issues.apache.org/jira/browse/HADOOP-7322
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7322-1.patch, HADOOP-7322-2.patch,
> HADOOP-7322-3.patch
>
>
> While testing Disk Fail Inplace, we encountered lots of NPE from
> Dir.listFiles API. This API can return null when Dir is not directory or disk
> is bad. I am proposing to have a File Util which can be used consistently
> across to deal with disk issues. This util api will do the following:
> 1. When error happens it will throw IOException
> 2. Else it will return empty list or list of files.
> Signature:
> File[] FileUtil.listFiles(File dir) throws IOException {}
> This way we no need to write wrapper code every where. Also, API is
> consistent with the signature.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira