[
https://issues.apache.org/jira/browse/HADOOP-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525367#comment-16525367
]
Aaron Fabbri commented on HADOOP-15215:
---------------------------------------
LGTM +1. Good work here [~gabor.bota]. I think findbugs should be happy after
your v2 patch, but I'll wait for green test before committing.
> s3guard set-capacity command to fail on read/write of 0
> -------------------------------------------------------
>
> Key: HADOOP-15215
> URL: https://issues.apache.org/jira/browse/HADOOP-15215
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.0.0
> Reporter: Steve Loughran
> Assignee: Gabor Bota
> Priority: Minor
> Attachments: HADOOP-15215.001.patch, HADOOP-15215.002.patch
>
>
> the command {{hadoop s3guard set-capacity -read 0 s3a://bucket}} will get
> all the way to the AWS SDK before it's rejected; if you pass in a value of -1
> we fail fast.
> The CLI check should really be failing on <= 0, not < 0.
> You still get a stack trace, so it's not that important.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
