[ 
https://issues.apache.org/jira/browse/HADOOP-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533061#comment-16533061
 ] 

Steve Loughran commented on HADOOP-15579:
-----------------------------------------

Gabor: seen you've put your name to this. Have a look at  HADOOP-15546  and see 
how it works.

 

For this test, I know what's wrong: it's really an integration test of a sort 
(subclass of DependencyInjectedTest) and with different deployment configs, can 
fail.

I think it could embrace this, and compare the config values if set, rather 
than just the defaults, as that would verify that things do get all the way 
through. That implies rename to ITest... and changed test logic

 

> ABFS: TestAbfsConfigurationFieldsValidation breaks if FS is configured in 
> core-site
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-15579
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15579
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: HADOOP-15407
>            Reporter: Steve Loughran
>            Priority: Major
>
> {{TestAbfsConfigurationFieldsValidation.testConfigServiceImplAnnotatedFieldsInitialized}}
> Will fail if you have configured any of
> the properties in your abfs defaults/core-defaults imports. It is therefore
> (a) not a unit test and (b) brittle



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to