[
https://issues.apache.org/jira/browse/HADOOP-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555116#comment-16555116
]
Xiao Chen commented on HADOOP-15593:
------------------------------------
If we did what's proposed in [my previous
comment|https://issues.apache.org/jira/browse/HADOOP-15593?focusedCommentId=16554585&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16554585],
the case when tgt is destroyed will be handled by the {{return}} statement.
In the rare race that the tgt gets destroyed after the code has gone after
those lines, the rest of the logic including the nextRefresh part you pointed
out does not depend on tgt anymore (it only depends on the local var
{{tgtEndTime}}). We should be fine just it retry one more time and return on
the tgt null check next time it enters the while loop.
So we don't need to change {{now > nextRefresh}} part of code. Did I miss
anything?
> UserGroupInformation TGT renewer throws NPE
> -------------------------------------------
>
> Key: HADOOP-15593
> URL: https://issues.apache.org/jira/browse/HADOOP-15593
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 3.0.0
> Reporter: Wei-Chiu Chuang
> Assignee: Gabor Bota
> Priority: Blocker
> Attachments: HADOOP-15593.001.patch, HADOOP-15593.002.patch,
> HADOOP-15593.003.patch, HADOOP-15593.004.patch
>
>
> Found the following NPE thrown in UGI tgt renewer. The NPE was thrown within
> an exception handler so the original exception was hidden, though it's likely
> caused by expired tgt.
> {noformat}
> 18/07/02 10:30:57 ERROR util.SparkUncaughtExceptionHandler: Uncaught
> exception in thread Thread[TGT Renewer for [email protected],5,main]
> java.lang.NullPointerException
> at
> javax.security.auth.kerberos.KerberosTicket.getEndTime(KerberosTicket.java:482)
> at
> org.apache.hadoop.security.UserGroupInformation$1.run(UserGroupInformation.java:894)
> at java.lang.Thread.run(Thread.java:748){noformat}
> Suspect it's related to [https://bugs.openjdk.java.net/browse/JDK-8154889].
> The relevant code was added in HADOOP-13590. File this jira to handle the
> exception better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
