[
https://issues.apache.org/jira/browse/HADOOP-15659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575792#comment-16575792
]
Thomas Marquardt commented on HADOOP-15659:
-------------------------------------------
Overall looks good to me. I would like a list with a short description of each
change, and then please address feedback below:
Use git apply --whitespace=fix to remove whitespace from your patch.
AbfsClient.java
L48 should have xMsVersion = "2018-06-17"
L63 Remove "this"
AbfsRestOperation.java
L51 Why static? Originally, this was using the public static logger field
from AbfsClient, but now calls getLogger which I assume returns a cached
logger? I definitely think we should use a single AbfsClient logger.
AbfsFileSystem.java
L473 Can you update this to call abfsStore.getFilesystemProperties() directly?
My test results match yours:
Tests run: 261, Failures: 0, Errors: 0, Skipped: 11
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
Tests run: 777, Failures: 0, Errors: 0, Skipped: 182
Tests run: 186, Failures: 0, Errors: 0, Skipped: 10
> ABFS: Code changes for bug fix and new tests
> --------------------------------------------
>
> Key: HADOOP-15659
> URL: https://issues.apache.org/jira/browse/HADOOP-15659
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Da Zhou
> Assignee: Da Zhou
> Priority: Major
> Attachments: HADOOP-15659-HADOOP-15407-001.patch
>
>
> - add bug fixes.
> - remove unnecessary dependencies.
> - add new tests for code changes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
