[
https://issues.apache.org/jira/browse/HADOOP-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580248#comment-16580248
]
Aaron Fabbri commented on HADOOP-14154:
---------------------------------------
Ah, interesting. The existing code appears to work ok with LocalMetadataStore.
Maybe it doesn't get {{changed == true}} in DynamoDBMetadataStore because that
implementation always creates ancestor directories all the way up the tree?
Just a theory.
It seems like the boolean {{changed}} in {{dirListingUnion()}} should also take
into account the auth bit. It is passed a param {{dirMeta}} which is the last
dir listing fetched from the MetadataStore, I believe. If
{{dirMeta.isAuthoritative == false}}, but {{isAuthoritative}} parameter is
true, we should probably set {{changed = true}} to force a write of the auth
bit for that directory. The next time that directory is listed it should skip
the extra write since both {{dirMeta.isAuthoritative}} and {{isAuthoritative}}
will be true. What do you think?
> Persist isAuthoritative bit in DynamoDBMetaStore (authoritative mode support)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-14154
> URL: https://issues.apache.org/jira/browse/HADOOP-14154
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.0.0-beta1
> Reporter: Rajesh Balamohan
> Assignee: Gabor Bota
> Priority: Minor
> Attachments: HADOOP-14154-HADOOP-13345.001.patch,
> HADOOP-14154-HADOOP-13345.002.patch, HADOOP-14154-spec-001.pdf,
> HADOOP-14154-spec-002.pdf, HADOOP-14154.001.patch, HADOOP-14154.002.patch,
> HADOOP-14154.003.patch, HADOOP-14154.004.patch, all-logs-v2.txt,
> perf-eval-v1.diff, perf-eval-v2.diff, run-dir-perf-itest-v2.sh,
> run-dir-perf-itest.sh
>
>
> Add support for "authoritative mode" for DynamoDBMetadataStore.
> The missing feature is to persist the bit set in
> {{DirListingMetadata.isAuthoritative}}.
> This topic has been super confusing for folks so I will also file a
> documentation Jira to explain the design better.
> We may want to also rename the DirListingMetadata.isAuthoritative field to
> .isFullListing to eliminate the multiple uses and meanings of the word
> "authoritative".
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
