[ https://issues.apache.org/jira/browse/HADOOP-15675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581340#comment-16581340 ]
Xiao Chen edited comment on HADOOP-15675 at 8/15/18 4:50 PM: ------------------------------------------------------------- Thanks Allen for the lightning triage! Agreed Yetus should rather fail so people can notice... I have pinged HDDFS-119 for the checkstyle fix as well. was (Author: xiaochen): Thanks Allen for the lightning triage! Agreed Yetus should rather fail so people can notice... I have pinged HDDFS-119 about this as well. > checkstyle fails to execute > --------------------------- > > Key: HADOOP-15675 > URL: https://issues.apache.org/jira/browse/HADOOP-15675 > Project: Hadoop Common > Issue Type: Bug > Components: build > Reporter: Kitti Nanasi > Priority: Minor > > If a patch is created with checkstyle errors, for example when a modified > line is longer than 80 characters, then running checkstyle with the > test-patch script runs to success (though it should fail and show an error > about the long line). > {code:java} > dev-support/bin/test-patch --plugins="-checkstyle" test.patch{code} > However it does show the error (so works correctly) when running it with the > IDEA checkstyle plugin. > > I only tried it out it for patches with too long lines and wrong indentation, > but I assume that it can be a more general problem. > We realised this when reviewing HDFS-13217, where patch 004 has a "too long > line" checkstyle error. In the first build for that patch, the checkstyle > report was showing the error, but when it was ran again with the same patch, > the error disappeared. So probably the checkstyle checking stopped working on > trunk somewhere between April and July 2018. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org