[ 
https://issues.apache.org/jira/browse/HADOOP-15674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582260#comment-16582260
 ] 

Gabor Bota edited comment on HADOOP-15674 at 8/16/18 9:33 AM:
--------------------------------------------------------------

Thanks for the v2 patch [~snemeth]!

I have a little concern on {{turnOffSSLDebugLogging}}. 
{{turnOnSSLDebugLogging}} sets {{javax.net.debug}} to all, but by turning it 
off you set it to an empty string. For {{https.cipherSuites}} you store, 
modify, and then restore the original setting. Could you do the same with 
{{javax.net.debug}}? It less likely to cause an issue in the future if someone 
wants to use {{javax.net.debug}} during other tests.


was (Author: gabor.bota):
Thanks for the v2 patch [~snemeth]!

I have a little concern on {{turnOffSSLDebugLogging}}. 
{{turnOnSSLDebugLogging}} sets {{javax.net.debug}} to debug, but by turning it 
off you set it to an empty string. For {{https.cipherSuites}} you store, 
modify, and then restore the original setting. Could you do the same with 
{{javax.net.debug}}? It less likely to cause an issue in the future if someone 
wants to use {{javax.net.debug}} during other tests.

> Test failure TestSSLHttpServer.testExcludedCiphers with 
> TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 cipher suite
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-15674
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15674
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: common
>    Affects Versions: 2.6.0
>            Reporter: Gabor Bota
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: HADOOP-15674-branch-2.001.patch, 
> HADOOP-15674-branch-2.002.patch, HADOOP-15674-branch-3.0.0.001.patch, 
> HADOOP-15674-branch-3.0.0.002.patch, HADOOP-15674.001.patch, 
> HADOOP-15674.002.patch
>
>
> Running {{hadoop/hadoop-common-project/hadoop-common# mvn test 
> -Dtest="TestSSLHttpServer#testExcludedCiphers" -Dhttps.protocols=TLSv1.2 
> -Dhttps.cipherSuites=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256}} fails with:
> {noformat}
> Error Message
> No Ciphers in common, SSLHandshake must fail.
> Stacktrace
>       java.lang.AssertionError: No Ciphers in common, SSLHandshake must fail.
>       at org.junit.Assert.fail(Assert.java:88)
>       at 
> org.apache.hadoop.http.TestSSLHttpServer.testExcludedCiphers(TestSSLHttpServer.java:178)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to